After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765991 - Compilation of gresource.c is broken due to S_ISDIR
Compilation of gresource.c is broken due to S_ISDIR
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-05-04 14:58 UTC by Fan, Chun-wei
Modified: 2016-05-04 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gresource.c: Use g_file_test() instead of g_stat() and S_ISDIR (1022 bytes, patch)
2016-05-04 15:02 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2016-05-04 14:58:12 UTC 
Hi,

A recent commit used the S_ISDIR macro that is actually not available universally, which broke the build on compilers which do not support it.

I will attach a simple patch to address this issue.

With blessings, thank you!
Comment 1 Fan, Chun-wei 2016-05-04 15:02:26 UTC 
Created attachment 327303 [details] [review]
gresource.c: Use g_file_test() instead of g_stat() and S_ISDIR

Hi,

This is my proposal to fix the build of gio/gresource.c on compilers which do not support S_ISDIR.

With blessings, thank you!
Comment 2 Colin Walters 2016-05-04 15:07:01 UTC 
Review of attachment 327303 [details] [review]:

One minor fixup, feel free to push after that.

::: gio/gresource.c
@@ +251,1 @@
           GStatBuf buf;

You can also drop this variable now.
Comment 3 Fan, Chun-wei 2016-05-04 15:52:43 UTC 
Hi Colin,

Thanks, I pushed the patch with the fix you mentioned as 217b620.

With blessings, thank you!