GNOME Bugzilla – Bug 765941
Add backbutton after screenshot
Last modified: 2017-09-21 19:54:32 UTC
Can a back button be added to GNOME-screenshot? After someone takes a screenshot of an area it would be cool if they could click a back button instead of closing the application and reopening it if someone took a bad screenshot they didn't want to save.
It would be really helpful, if there would be an option (E.g. additional button) in order to take an other screenshot.
Created attachment 350353 [details] [review] Updated to support back button after screenshot
Review of attachment 350353 [details] [review]: Thanks, this looks pretty good. Only a couple of minor comments below. ::: src/screenshot-application.c @@ +402,3 @@ + save_folder_to_settings (self); + gtk_widget_destroy (dialog->dialog); + g_free (dialog); Could you factor out these lines into a separate function? It looks like they're also called from https://git.gnome.org/browse/gnome-screenshot/tree/src/screenshot-application.c#n114 @@ +432,3 @@ break; + case SCREENSHOT_RESPONSE_BACK: + screenshot_back(self); Add missing space before paren
Created attachment 356563 [details] [review] added in changes from review applied changes from code review
Daniel, thanks for the updated patch! However, I notice that you have only attached a diff from the previous version to the one with the latest changes. Instead, please re-attach the whole diff as a single git-formatted patch. (See https://wiki.gnome.org/Git/Developers#Contributing_patches for more information on how you can accomplish that.)
Created attachment 356621 [details] [review] complete patch for back button
Thanks! I tweaked a bit the layout and used an icon button instead of a textual one, since that's what all the other GNOME apps use for this pattern, and committed the patch to master.
*** Bug 730618 has been marked as a duplicate of this bug. ***