After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765885 - client side decoration, no space to add header bar
client side decoration, no space to add header bar
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: user interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-01 19:43 UTC by oly
Modified: 2017-09-09 22:23 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20


Attachments
screenshot of missing space when client side decoration has been clicked (24.10 KB, image/jpeg)
2016-05-01 19:43 UTC, oly
Details
Screenshot with examples which demonstrate the bug (129.05 KB, image/jpeg)
2017-02-27 15:08 UTC, Francisco Gómez
Details

Description oly 2016-05-01 19:43:28 UTC
Created attachment 327118 [details]
screenshot of missing space when client side decoration has been clicked

Using glade nightly from xdg-app, when i click the client side decorations for a window previously you would get a space to insert your headerbar or widget this no long seems to show.

expecting a space when i click client side decorations so i can insert a headerbar, currently all i can do is insert the header bar in a grid but the window bar still shows.
Comment 1 Matthias Clasen 2016-05-02 10:29:50 UTC
This warning explains whats going on:

(glade:18337): Gtk-WARNING **: gtk_window_set_titlebar() called on a realized window
Comment 2 oly 2016-05-02 11:31:50 UTC
well it kind of explains why, but surely i should be able to add the headerbar in glade, even if glade has realized the window, you used to be able todo it.

This is before i have written any of my own code.
Comment 3 Tristan Van Berkom 2016-05-02 15:46:44 UTC
(In reply to Matthias Clasen from comment #1)
> This warning explains whats going on:
> 
> (glade:18337): Gtk-WARNING **: gtk_window_set_titlebar() called on a
> realized window

FWIW, I'm pretty sure that that warning has been there since we originally landed the CSD option.
Comment 4 oly 2016-05-04 07:27:59 UTC
Seems dialogs still work, if i add a dialog or assistant widget and click client side decorations I have a space for the header bar.

Its only windows and application windows that the space is missing to insert the headerbar.
Comment 5 Yannick Inizan 2016-05-04 19:19:02 UTC
same error for me (glade version : 3.20.0)

the Gtk warning appears for Window & Dialog, but I can set headerbar on dialog
Comment 6 Michael Murphy 2016-05-13 14:15:28 UTC
This bug has been here since 3.18 released, but I haven't gotten around to reporting it. It's even worse if you open a glade file that contains a headerbar on a window because it will just display a blank window. At one time it did work, at least it did with 3.16.
Comment 7 Juan Pablo Ugarte 2016-05-13 22:15:38 UTC
Fixed in master and glade-3-20

The problem was that at some point we added a call to gtk_window_set_decorated (false) to avoid windows decorations in the workspace on wayland

So I fixed it by always adding a placeholder as the titlebar and hiding it if not necessary!
Comment 8 oly 2016-05-15 08:31:28 UTC
Great work, updated the glade xdg app and its now fixed and i can move the headerbar to the correct place :)
Comment 9 Frank 2017-01-19 17:50:17 UTC
Juan, could you please backport this to 3.20? I'm running F25 with Glade 3.20.0 and still have this bug.
Comment 10 Francisco Gómez 2017-02-27 15:08:08 UTC
Created attachment 346826 [details]
Screenshot with examples which demonstrate the bug

Hello! I just have both compiled the latest commit from the master branch and applied the commit 7b0aa0166486e5c85973960ebb54f31790754ffc as a patch over Glade 3.20.0, and none of them seem to have fixed the problem.

The attached screenshot shows my trunk build (from commit ffc16cedffd3681708e645479e9473d4ca89accb on master) failing to show up either a placeholder space or an inserted GtkHeaderBar on the CSD display area.

Do you know why is this, or how could it be debugged? Thank you in advance!
Comment 11 Stephen 2017-09-09 21:18:13 UTC
Can a 3.20.1 release be made to make this fix available? Unless Fancisco's comment means there's still some issue with the fix itself?
Comment 12 Frank 2017-09-09 22:23:46 UTC
In nightly it works for the most part, otherwise Glade seems deprecated, since there are a lot of issues and no one works on these. :/