After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765719 - pad: fix buffer leaks in test
pad: fix buffer leaks in test
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-28 11:56 UTC by Guillaume Desmottes
Modified: 2016-05-02 06:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstpad: fix buffer leaks in tests (1.28 KB, patch)
2016-04-28 11:57 UTC, Guillaume Desmottes 		none Details | Review
gstpad: fix buffer leaks in tests (2.49 KB, patch)
2016-05-02 05:22 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-04-28 11:56:14 UTC 
Some buffers are leaked in the pad unit tests.
Comment 1 Guillaume Desmottes 2016-04-28 11:57:26 UTC 
Created attachment 326935 [details] [review]
gstpad: fix buffer leaks in tests

The buffer received through the pad have to be unreffed using
gst_check_drop_buffers().
Comment 2 Sebastian Dröge (slomo) 2016-04-29 07:01:22 UTC 
Comment on attachment 326935 [details] [review]
gstpad: fix buffer leaks in tests

You missed some, e.g. test_push_linked. There are more gst_check_chain_func usages than gst_check_drop_buffers
Comment 3 Guillaume Desmottes 2016-05-02 05:22:31 UTC 
Created attachment 327126 [details] [review]
gstpad: fix buffer leaks in tests

The buffer received through the pad have to be unreffed using
gst_check_drop_buffers().
Comment 4 Sebastian Dröge (slomo) 2016-05-02 06:54:39 UTC 
commit 3146c12a67ac7d1d4a897442dfca8bfb6052033c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Apr 28 14:56:18 2016 +0300

    pad: fix buffer leaks in tests
    
    The buffer received through the pad have to be unreffed using
    gst_check_drop_buffers().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765719