After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765710 - gdbus-tool: only print note about expected argument types if that was actually the problem
gdbus-tool: only print note about expected argument types if that was actuall...
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-04-28 08:58 UTC by Allison Karlitskaya (desrt)
Modified: 2016-04-29 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdbus-tool: avoid irrelevent note about arg types (3.03 KB, patch)
2016-04-28 08:58 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2016-04-28 08:58:02 UTC
gdbus-tool prints a hint about the expected arguments to a function call
in case of errors.  Unfortunately, it prints this message on all errors.
I've seen this confuse users several times -- they go on tweaking the
arguments trying to get the correct type, even though they had it
correct in the first place.

Let's limit the hint to the case where it was actually invalid arguments
that triggered the problem.  Also, adjust the code that prints the
message so that it will also report on the case that no arguments were
expected.

We could possibly get closer to what we want by comparing the list of
expected arguments with the parameter list, as it was parsed from the
user, but that would involve composing the expected type.  Let's keep
this simple for now.
Comment 1 Allison Karlitskaya (desrt) 2016-04-28 08:58:07 UTC
Created attachment 326924 [details] [review]
gdbus-tool: avoid irrelevent note about arg types
Comment 2 Allison Karlitskaya (desrt) 2016-04-28 09:26:08 UTC
(already fixed the glaring typo in the commit summary)
Comment 3 Colin Walters 2016-04-28 20:20:31 UTC
Review of attachment 326924 [details] [review]:

Nice, LGTM.