After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765708 - encoding-profile: Make creation of encoding profile from discoverer info more robust
encoding-profile: Make creation of encoding profile from discoverer info more...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-28 08:31 UTC by Sebastian Dröge (slomo)
Modified: 2016-05-04 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
encoding-profile: Move adding of each stream to a helper function (3.71 KB, patch)
2016-04-28 08:31 UTC, Sebastian Dröge (slomo) 		committed Details | Review
encoding-profile: Fail to create encoding profile from discoverer info if no streams could be added (1.96 KB, patch)
2016-04-28 08:31 UTC, Sebastian Dröge (slomo) 		committed Details | Review
encoding-profile: Recurse into nested container profiles and only add the final audio/video streams (1.65 KB, patch)
2016-04-28 08:31 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-04-28 08:31:38 UTC 
See commit messages
Comment 1 Sebastian Dröge (slomo) 2016-04-28 08:31:41 UTC 
Created attachment 326920 [details] [review]
encoding-profile: Move adding of each stream to a helper function
Comment 2 Sebastian Dröge (slomo) 2016-04-28 08:31:47 UTC 
Created attachment 326921 [details] [review]
encoding-profile: Fail to create encoding profile from discoverer info if no streams could be added
Comment 3 Sebastian Dröge (slomo) 2016-04-28 08:31:52 UTC 
Created attachment 326922 [details] [review]
encoding-profile: Recurse into nested container profiles and only add the final audio/video streams

If we e.g. have AVI with DV container with video/audio inside the DV
container, we can't handle this at this point with an encoding profile.
Instead of erroring out, flatten the container hierarchy.
Comment 4 Sebastian Dröge (slomo) 2016-04-29 07:12:54 UTC 
Attachment 326920 [details] pushed as 436adc6 - encoding-profile: Move adding of each stream to a helper function
Attachment 326921 [details] pushed as 4c2e7ae - encoding-profile: Fail to create encoding profile from discoverer info if no streams could be added
Attachment 326922 [details] pushed as e2bde25 - encoding-profile: Recurse into nested container profiles and only add the final audio/video streams