After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765617 - common: Fix search by skipping soft hyphens when normalizing
common: Fix search by skipping soft hyphens when normalizing
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-26 14:56 UTC by Rui Matos
Modified: 2016-04-26 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Fix search by skipping soft hyphens when normalizing (1.41 KB, patch)
2016-04-26 14:56 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-04-26 14:56:26 UTC 
There's also an issue with displaying the panel names. Right now I'm
seeing e.g.

  Region & Lan
     guage

by default on an english system. Should we remove the hyphens from the
original strings and leave the issue to translators (certainly keeping
the translator comments).
Comment 1 Rui Matos 2016-04-26 14:56:30 UTC 
Created attachment 326782 [details] [review]
common: Fix search by skipping soft hyphens when normalizing

Commit b3be07609a9bae43947ee3e59d8982a7715c9acf introduced soft
hyphens in panel names which causes searches to fail. Fix this by
skipping soft hyphen when normalizing strings.
Comment 2 Bastien Nocera 2016-04-26 14:57:55 UTC 
(In reply to Rui Matos from comment #0)
> There's also an issue with displaying the panel names. Right now I'm
> seeing e.g.
> 
>   Region & Lan
>      guage
> 
> by default on an english system. Should we remove the hyphens from the
> original strings and leave the issue to translators (certainly keeping
> the translator comments).

No, because we have the same problem with all the languages, including English in some cases.
Comment 3 Bastien Nocera 2016-04-26 14:58:13 UTC 
Review of attachment 326782 [details] [review]:

Looks good.
Comment 4 Rui Matos 2016-04-26 15:18:29 UTC 
2b9a0ac..d40be80  gnome-3-20 -> gnome-3-20
      c831eaa..11d5d85  master -> master

Attachment 326782 [details] pushed as 11d5d85 - common: Fix search by skipping soft hyphens when normalizing