After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765493 - kineticscrolling: avoid stutter at tail of kinetic deceleration
kineticscrolling: avoid stutter at tail of kinetic deceleration
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-04-24 09:32 UTC by Christian Hergert
Modified: 2016-04-24 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
kineticscrolling: avoid stutter at tail of kinetic deceleration (1.64 KB, patch)
2016-04-24 09:32 UTC, Christian Hergert
none Details | Review
kineticscrolling: avoid stutter at tail of kinetic deceleration (1.68 KB, patch)
2016-04-24 09:42 UTC, Christian Hergert
committed Details | Review

Description Christian Hergert 2016-04-24 09:32:20 UTC
This is based on an IRC discussion the other night with mclasen. Simple
solution to stop the deceleration phase when it no longer has us moving by
whole pixels.

I tested a couple other platforms and this seems to be the same technique they
apply based on my imperical evidence.
Comment 1 Christian Hergert 2016-04-24 09:32:26 UTC
Created attachment 326624 [details] [review]
kineticscrolling: avoid stutter at tail of kinetic deceleration

When decelerating the kinetic scroll, we can get into a position where it
looks like we are stuttering. This happens because the amount we move is
so little that it takes multiple frames to make forward progress by one
pixel.

This prevents that by detecting when we have reached the slow stutter of
the deceleration and simply stops the deceleration phase immediately.
Comment 2 Christian Hergert 2016-04-24 09:42:24 UTC
Created attachment 326626 [details] [review]
kineticscrolling: avoid stutter at tail of kinetic deceleration

Cleanup styling for readability.
Comment 3 Emmanuele Bassi (:ebassi) 2016-04-24 10:23:29 UTC
Review of attachment 326626 [details] [review]:

Looks reasonable.
Comment 4 Christian Hergert 2016-04-24 10:49:48 UTC
Attachment 326626 [details] pushed as 4f63d83 - kineticscrolling: avoid stutter at tail of kinetic deceleration