After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765489 - New Folder greyed out after closing a tab
New Folder greyed out after closing a tab
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Main Toolbar
3.20.x
Other Linux
: Normal normal
: 3.20
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-24 06:42 UTC by Neil Herald
Modified: 2016-04-25 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
files-view: remove action group only matches view group (2.16 KB, patch)
2016-04-25 15:08 UTC, Carlos Soriano
committed Details | Review

Description Neil Herald 2016-04-24 06:42:14 UTC
To reproduce: 
1. Open a new tab (with the action menu item, or Ctrl+T)
2. Close the new tab
3. Open the action menu: the "New Folder" option is greyed out

Expected behaviour: 
New Folder shouldn't be greyed out. 

Happens in nautilus master and 3.18.5. Can't get 3.20 to build, but I presume it also happens there.
Comment 1 Carlos Soriano 2016-04-25 15:08:35 UTC
Created attachment 326696 [details] [review]
files-view: remove action group only matches view group

We were removing the action group when the parent is unset.
However, this removes the action group from the window unconditionally,
meaning that if the view that the parent is unset for is not the current
view it will remove the action group of the actual current view, making
the actions unreachable outside of the view.

This was causing the action menu in the toolbar to have non activatable
actions.

To fix it, make sure we remove the action group only if it matches the
current one attached to the window.
Comment 2 Carlos Soriano 2016-04-25 15:59:49 UTC
Attachment 326696 [details] pushed as c48d702 - files-view: remove action group only matches view group