After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765444 - Does not build against recent freerdp
Does not build against recent freerdp
Status: RESOLVED OBSOLETE
Product: vinagre
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-22 22:44 UTC by Adam Williamson
Modified: 2021-05-26 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
handle both 'freerdp' and 'freerdp2' pkgconfig module names (1.32 KB, patch)
2016-04-22 22:44 UTC, Adam Williamson
none Details | Review

Description Adam Williamson 2016-04-22 22:44:39 UTC
Created attachment 326580 [details] [review]
handle both 'freerdp' and 'freerdp2' pkgconfig module names

Since this change to freerdp:

https://github.com/FreeRDP/FreeRDP/commit/6fa36081112c46951096cddfacc0f760e4728b25

vinagre no longer builds successfully, because the pkgconfig module name is different. Attaching a patch which makes it work both ways (but it's a bit ugly). With this, vinagre builds OK in Fedora Rawhide.
Comment 1 Yaakov Selkowitz 2017-03-07 21:53:04 UTC
(In reply to Adam Williamson from comment #0)
> With this, vinagre builds OK in Fedora Rawhide.

Even this is no longer true since the October 2016 API changes to FreeRDP.
Comment 2 Peter 2017-05-14 15:17:04 UTC
Confirmed issue. The patch in https://bugs.gentoo.org/show_bug.cgi?id=609474 together with patch suggested here work.
Comment 3 Pacho Ramos 2017-08-04 08:47:14 UTC
This is ArchLinux patch to fix compilation with current freerdp:
https://git.archlinux.org/svntogit/packages.git/plain/trunk/freerdp2017.diff?h=packages/vinagre
Comment 4 André Klapper 2021-05-26 09:25:03 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Vinagre, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/vinagre/-/issues/

Thank you for your understanding and your help.