After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765368 - plugins: rework set_context() vmethod definition
plugins: rework set_context() vmethod definition
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 764673
 
 
Reported: 2016-04-21 11:22 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-04-29 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: rework set_context() vmethod definition (7.00 KB, patch)
2016-04-21 11:22 UTC, Víctor Manuel Jáquez Leal 		none Details | Review
plugins: rework set_context() vmethod definition (7.33 KB, patch)
2016-04-21 11:34 UTC, Víctor Manuel Jáquez Leal 		none Details | Review
plugins: rework set_context() vmethod definition (7.36 KB, patch)
2016-04-21 13:23 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-04-21 11:22:39 UTC 
see patch log message
Comment 1 Víctor Manuel Jáquez Leal 2016-04-21 11:22:43 UTC 
Created attachment 326478 [details] [review]
plugins: rework set_context() vmethod definition

In bug 757598 was added the set_context() vmethod chain up in
GstVaapiPluginBase. But it is buggy, since the parent_class address is
assigned to the last element which called gst_vaapi_plugin_base_class_init().

No error has shown up since none of the element's base classes redefined
set_context() vmethod from GstElement, so always the correct function was
called. Still this code is wrong and this patch make it right.

Since set_context() is the same code, a macro is used to implement that code
in all the gst-vaapi elements.
Comment 2 Víctor Manuel Jáquez Leal 2016-04-21 11:34:03 UTC 
Created attachment 326479 [details] [review]
plugins: rework set_context() vmethod definition

In bug 757598 was added the set_context() vmethod chain up in
GstVaapiPluginBase. But it is buggy, since the parent_class address is
assigned to the last element which called gst_vaapi_plugin_base_class_init().

No error has shown up since none of the element's base classes redefined
set_context() vmethod from GstElement, so always the correct function was
called. Still this code is wrong and this patch make it right.

Since set_context() is the same code, a macro is used to implement that code
in all the gst-vaapi elements.
Comment 3 Víctor Manuel Jáquez Leal 2016-04-21 13:23:28 UTC 
Created attachment 326488 [details] [review]
plugins: rework set_context() vmethod definition

In bug 757598 was added the set_context() vmethod chain up in
GstVaapiPluginBase. But it is buggy, since the parent_class address is
assigned to the last element which called gst_vaapi_plugin_base_class_init().

No error has shown up since none of the element's base classes redefined
set_context() vmethod from GstElement, so always the correct function was
called. Still this code is wrong and this patch make it right.

Since set_context() is the same code, a macro is used to implement that code
in all the gst-vaapi elements.
Comment 4 Víctor Manuel Jáquez Leal 2016-04-22 15:23:34 UTC 
Attachment 326488 [details] pushed as bccdda8 - plugins: rework set_context() vmethod definition