Bug 765329 – [review] expose auth-dialog information in NMVpnPluginInfo and use in nm-applet

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 765329 - [review] expose auth-dialog information in NMVpnPluginInfo and use in nm-applet


Summary:	[review] expose auth-dialog information in NMVpnPluginInfo and use in nm-applet


Status:	RESOLVED FIXED

Product:	NetworkManager
Classification:	Platform
Component:	general
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	NetworkManager maintainer(s)
QA Contact:	NetworkManager maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:	767197

Reported:	2016-04-20 15:00 UTC by Thomas Haller
Modified:	2016-06-03 15:30 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Thomas Haller 2016-04-20 15:00:15 UTC

Please review

Comment 1 Thomas Haller 2016-04-20 15:02:23 UTC

On NetworkManager:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=th/vpn-auth-dialog-bgo765329


on nm-applet:

https://git.gnome.org/browse/network-manager-applet/log/?h=th/vpn-auth-dialog-bgo765329

Comment 2 Lubomir Rintel 2016-04-21 10:44:24 UTC

Looks nice.

Comment 3 Beniamino Galvani 2016-04-22 12:11:36 UTC

LGTM

Comment 4 Thomas Haller 2016-04-22 12:27:06 UTC

Thanks.


Merged to master:

NetworkManager:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2d59e70c6f8161bf2fe08a05351a7e3d826834ff

nm-applet:
https://git.gnome.org/browse/network-manager-applet/commit/?id=762f7ddea1749bae096f2e9442db29ce4da5b14a

Comment 5 David Woodhouse 2016-06-03 15:30:12 UTC

Aliases handling fixed for gnome-shell too by https://bugzilla.gnome.org/show_bug.cgi?id=658484#c59