After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765320 - flvmux: segfault when no buffers have arrived before EOS
flvmux: segfault when no buffers have arrived before EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.6.0
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-20 11:48 UTC by dyudaken
Modified: 2016-04-22 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flv: Handle the case where we do not get any CollectData in handle_buffer (877 bytes, patch)
2016-04-21 17:11 UTC, Thibault Saunier 		committed Details | Review

Description dyudaken 2016-04-20 11:48:49 UTC 
To reproduce:
gst_launch videotestsrc num-buffers=0 ! videoconvert ! x264enc ! flvmux ! fakesink

Result:
Segfaults

Relevant stacktrace:

+ Trace 236193

  • #0 gst_flv_mux_handle_buffer
    at <DEV>/gst-plugins-good/1.6.2/src/gst-plugins-good-1.6.2/gst/flv/gstflvmux.c line 1588
  • #1 gst_collect_pads_default_collected
    at <DEV>/gstreamer/1.6.2/src/gstreamer-1.6.2/libs/gst/base/gstcollectpads.c line 1558
  • #2 gst_collect_pads_check_collected
    at <DEV>/gstreamer/1.6.2/src/gstreamer-1.6.2/libs/gst/base/gstcollectpads.c line 1352
  • #3 gst_collect_pads_event_default
    at <DEV>/gstreamer/1.6.2/src/gstreamer-1.6.2/libs/gst/base/gstcollectpads.c line 1796
  • #4 gst_flv_mux_handle_sink_event
    at <DEV>/gst-plugins-good/1.6.2/src/gst-plugins-good-1.6.2/gst/flv/gstflvmux.c line 345
  • #5 gst_collect_pads_event
    at <DEV>/gstreamer/1.6.2/src/gstreamer-1.6.2/libs/gst/base/gstcollectpads.c line 2018 

I haven't tested on later Gstreamer unfortuantely as I have no access to it.
Comment 1 Sebastian Dröge (slomo) 2016-04-20 12:08:20 UTC 
Crashes in 1.8 and GIT master too
Comment 2 Thibault Saunier 2016-04-21 17:11:09 UTC 
Created attachment 326512 [details] [review]
flv: Handle the case where we do not get any CollectData in handle_buffer
Comment 3 Sebastian Dröge (slomo) 2016-04-22 07:05:41 UTC 
Comment on attachment 326512 [details] [review]
flv: Handle the case where we do not get any CollectData in handle_buffer

Also for 1.8 I guess
Comment 4 Thibault Saunier 2016-04-22 11:40:14 UTC 
Attachment 326512 [details] pushed as dd9bfd0 - flv: Handle the case where we do not get any CollectData in handle_buffer