After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765295 - Invalid memory access when reading G_FILE_ATTRIBUTE_THUMBNAIL_PATH
Invalid memory access when reading G_FILE_ATTRIBUTE_THUMBNAIL_PATH
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.20.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-20 08:29 UTC by Debarshi Ray
Modified: 2016-04-20 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
base-item: Avoid pointing to invalid memory (3.44 KB, patch)
2016-04-20 08:30 UTC, Debarshi Ray 		committed Details | Review
[gnome-3-20] base-item: Avoid pointing to invalid memory (3.78 KB, patch)
2016-04-20 08:31 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-04-20 08:29:43 UTC 
Ever since we fixed the GFileInfo leaks in commit a0aeb74da414ccebabf208d4753c9fab5594c929 and commit d93b3f5710f725e719952e56e5fce16da89bc010 priv->thumb_path in src/photos-base-item.c is pointing to invalid memory. It should keep its own copy of the string representing the path.

One user visible consequence is that toggling the favourites button leads to the 'broken thumbnail' placeholder being shown.

This affects both master and gnome-3-20.
Comment 1 Debarshi Ray 2016-04-20 08:30:51 UTC 
Created attachment 326385 [details] [review]
base-item: Avoid pointing to invalid memory
Comment 2 Debarshi Ray 2016-04-20 08:31:58 UTC 
Created attachment 326386 [details] [review]
[gnome-3-20] base-item: Avoid pointing to invalid memory
Comment 3 Rafael Fonseca 2016-04-20 12:45:05 UTC 
Review of attachment 326385 [details] [review]:

r+
Comment 4 Debarshi Ray 2016-04-20 18:29:44 UTC 
Thanks for the review, Rafael.