After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765252 - fix warning due implicit declaration of function
fix warning due implicit declaration of function
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-19 09:37 UTC by Victor Toso
Modified: 2016-04-20 07:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
include math.h (779 bytes, patch)
2016-04-19 09:38 UTC, Victor Toso
accepted-commit_now Details | Review

Description Victor Toso 2016-04-19 09:37:32 UTC
...
  CC       backends/meta-monitor-config.lo
backends/meta-cursor-renderer.c: In function ‘meta_cursor_renderer_calculate_rect’:
backends/meta-cursor-renderer.c:112:15: error: implicit declaration of function ‘roundf’ [-Werror=implicit-function-declaration]
     .x = (int)roundf (priv->current_x - (hot_x * texture_scale)),
               ^
backends/meta-cursor-renderer.c:112:15: error: incompatible implicit declaration of built-in function ‘roundf’ [-Werror]
backends/meta-cursor-renderer.c:112:15: note: include ‘<math.h>’ or provide a declaration of ‘roundf’
cc1: all warnings being treated as errors
Comment 1 Victor Toso 2016-04-19 09:38:22 UTC
Created attachment 326314 [details] [review]
include math.h
Comment 2 Florian Müllner 2016-04-19 10:33:36 UTC
Review of attachment 326314 [details] [review]:

Sure
Comment 3 Florian Müllner 2016-04-19 10:33:39 UTC
Review of attachment 326314 [details] [review]:

Sure
Comment 4 Victor Toso 2016-04-20 07:25:39 UTC
I forgot to use git-bz to push it.

Pushed as ff312b69585cb0ec9f53483baa47678db8d44306
https://git.gnome.org/browse/mutter/commit/?id=ff312b69585cb