After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765124 - Update configure.ac
Update configure.ac
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-15 20:57 UTC by Kunaal Jain
Modified: 2016-04-16 04:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: bump gtk+ version (723 bytes, patch)
2016-04-15 20:59 UTC, Kunaal Jain
committed Details | Review

Description Kunaal Jain 2016-04-15 20:57:50 UTC
On IRC <bjsnider> building and running with a gtk3 less than 3.20 results in a successful build but an immediate segfault when running.

We depend on many changes of Gtk version 3.19 or you can say 3.20. Update configure.ac to reflect the same. Should we use 3.20.0 or 3.19.12?
Comment 1 Kunaal Jain 2016-04-15 20:59:11 UTC
Created attachment 326138 [details] [review]
configure: bump gtk+ version
Comment 2 Florian Müllner 2016-04-15 21:29:13 UTC
Review of attachment 326138 [details] [review]:

(In reply to Kunaal Jain from comment #0)
> On IRC <bjsnider> building and running with a gtk3 less than 3.20 results in
> a successful build but an immediate segfault when running.

Technically that's not a bug, as the build-time requirements in configure.ac are satisfied and we don't actually have any checks for runtime dependencies (see the "missing" checks for telepathy-logger and libsecret). Still, it doesn't hurt to match the runtime requirement where there's an existent build-time dependency, so OK.
Comment 3 Kunaal Jain 2016-04-16 04:06:31 UTC
(In reply to Florian Müllner from comment #2)
> Technically that's not a bug, as the build-time requirements in configure.ac
> are satisfied and we don't actually have any checks for runtime dependencies
> (see the "missing" checks for telepathy-logger and libsecret). Still, it
> doesn't hurt to match the runtime requirement where there's an existent
> build-time dependency, so OK.

I will see that. I opened this bug because I wanted to get the patch reviewed :-)
Comment 4 Kunaal Jain 2016-04-16 04:11:15 UTC
Attachment 326138 [details] pushed as 3c70c73 - configure: bump gtk+ version