After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765066 - GtkColorChooser looks like it can select multiple colors
GtkColorChooser looks like it can select multiple colors
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkColorChooser
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-04-14 17:31 UTC by Timm Bäder
Modified: 2016-04-14 19:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot of the problem (23.86 KB, image/png)
2016-04-14 17:31 UTC, Timm Bäder 		  Details
iconhelper: Invalidate on clear() (950 bytes, patch)
2016-04-14 19:05 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Timm Bäder 2016-04-14 17:31:31 UTC 
Created attachment 326043 [details]
screenshot of the problem

See attached screenshot. The superfluous checkmarks disappear after an additional hover with the mouse (so I guess a redraw is enough?).
Comment 1 Matthias Clasen 2016-04-14 17:39:15 UTC 
can you bisect this ?
Comment 2 Timm Bäder 2016-04-14 18:21:46 UTC 
Bisected this to

commit 71a5f07620449be45067084b78183bb5661d5eb1
Author: Benjamin Otte <otte@redhat.com>
Date:   Wed Mar 30 21:41:08 2016 +0200

    widget: queue a redraw only if resize highlighting is enabled
    
    e8aa9b0440e03e7002323922f862342db51c5f32 introduced a new debug mode
    that highlights resizes. Unfortunately it has the side effect of
    always queueing redraws even when the debug mode

I just started from mid-march, but I guess this just means the bug was there before but didn't surface because we were just redrawing everything all the time?
Comment 3 Benjamin Otte (Company) 2016-04-14 19:05:54 UTC 
Created attachment 326048 [details] [review]
iconhelper: Invalidate on clear()

When clearing the icon helper, we need to invalidate it. Otherwise the
previous icon keeps lingering along.
This is not relevant inside gtkiconhelper.c where other code causes the
invalidation, but happens when external code calls
_gtk_icon_helper_clear().
Comment 4 Matthias Clasen 2016-04-14 19:17:14 UTC 
Attachment 326048 [details] pushed as 3bc58d0 - iconhelper: Invalidate on clear()