After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765064 - kmssink only works on the first crtc
kmssink only works on the first crtc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-14 15:56 UTC by Philipp Zabel
Modified: 2016-10-31 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kmssink: add sync support for secondary pipes (2.54 KB, patch)
2016-04-14 15:56 UTC, Philipp Zabel 		committed Details | Review

Description Philipp Zabel 2016-04-14 15:56:20 UTC 
Created attachment 326029 [details] [review]
kmssink: add sync support for secondary pipes

Currently kmssink syncs to a vblank event on the first crtc regardless on which crtc it actually creates the plane. This causes it to hang when using on any but the first crtc.
Comment 1 Víctor Manuel Jáquez Leal 2016-04-14 16:31:00 UTC 
Comment on attachment 326029 [details] [review]
kmssink: add sync support for secondary pipes

Thanks for the patch.

Did you check if it is possible to use this self->pipe in find_plane_for_crtc()?

Perhaps we could simplify that function since we already have the pipe. Or am I saying nonsense?
Comment 2 Víctor Manuel Jáquez Leal 2016-04-19 09:09:52 UTC 
(In reply to Víctor Manuel Jáquez Leal from comment #1)
> 
> Did you check if it is possible to use this self->pipe in
> find_plane_for_crtc()?
> 
> Perhaps we could simplify that function since we already have the pipe. Or
> am I saying nonsense?

As usual, I was saying nonsense :)

I'll push it as is.
Comment 3 Víctor Manuel Jáquez Leal 2016-04-19 09:16:14 UTC 
Attachment 326029 [details] pushed as b2c58d3 - kmssink: add sync support for secondary pipes