Created attachment 326011 [details] [review]
cursor: Do not try to unref NULL CoglObject

Created attachment 326012 [details] [review]
Do not skip CoglError parameters

While CoglError is a define to GError, it doesn't follow the convention
of ignoring errors when NULL is passed, but rather treats the error as
fatal :-(
That's clearly unwanted for a compositor, so make sure to always pass
an error parameter where a runtime error is possible (i.e. any CoglError
that is not a malformed blend string).

Created attachment 326013 [details] [review]
Do not skip CoglError parameters

Missed one bit ...

Review of attachment 326013 [details] [review]:

seems fine, I think the comment below should be addressed on the other patch

::: src/compositor/meta-surface-actor-x11.c
@@ +125,1 @@
+  if (error != NULL)

All the other cases seem fine, but this one in particular, if it fails, will leave priv->texture == NULL which will crash calling cogl_object_unref() on it in detach_pixmap()

Created attachment 326112 [details] [review]
Do not try to unref NULL CoglObjects

Ah yes, thanks for the catch!

Review of attachment 326112 [details] [review]:

lgtm

Attachment 326013 [details] pushed as 8842bdf - Do not skip CoglError parameters
Attachment 326112 [details] pushed as bdc72dd - Do not try to unref NULL CoglObjects

*** Bug 762038 has been marked as a duplicate of this bug. ***

Any chance this ends up in 3.18 as well?

I still had a 3.18 release pending to push out a fix for a regression in the previous version, and I've included those patches now.