After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765016 - Should not allow whitespace in VPN gateway entry
Should not allow whitespace in VPN gateway entry
Status: RESOLVED OBSOLETE
Product: NetworkManager
Classification: Platform
Component: VPN: openconnect
1.0.x
Other Linux
: Normal enhancement
: ---
Assigned To: David Woodhouse
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-13 19:40 UTC by yvan
Modified: 2020-11-12 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description yvan 2016-04-13 19:40:25 UTC
Hi,

This bug was originally reported on https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806600

It was using Debian with package network-manager-openconnect-gnome 0.9.10.0-1, but is still here with 1.0.2-1+b1.

Scenario:
A user is configuring a new VPN connection from the GUI: if he adds by mistake a whitespace in the VPN gateway entry, for example "vpn-gateway.com ", it will prevent the VPN connection from working. Removing the trailing whitespace solutions the problem.

Could the GUI be smart enough to remove white-spaces, or to warn the user?

Thanks for your time and work,
Yvan
Comment 1 David Woodhouse 2016-04-13 19:58:33 UTC
Whitespace is probably the wrong thing to check. But yes, a general validity check, allowing only a host name or valid URL (which *could* conceivably end with whitespace!) would be nice.

Need coherent way of indicating to user that one or more fields are invalid, rather than just greying out the "OK" button. And consistency across NM dialogs...
Comment 2 Thomas Haller 2016-04-13 20:40:48 UTC
(In reply to David Woodhouse from comment #1)

> Need coherent way of indicating to user that one or more fields are invalid,
> rather than just greying out the "OK" button. And consistency across NM
> dialogs...

There tool tip of the OK button shows actually the reason why the button is disabled. Yes, that could be improved (for better discoverability), but it's not that bad...
Comment 3 André Klapper 2020-11-12 14:35:08 UTC
bugzilla.gnome.org is being shut down in favor of a GitLab instance. 
We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time.

If you still use NetworkManager and if you still see this bug / want this feature in a recent and supported version of NetworkManager, then please feel free to report it at https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/

Thank you for creating this report and we are sorry it could not be implemented (workforce and time is unfortunately limited).