After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765000 - [review] refactor settings (especially "CONNECTION_UPDATED" signal) and fix active-connection's ID [th/settings-cleanup-bgo765000]
[review] refactor settings (especially "CONNECTION_UPDATED" signal) and fix a...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2016-04-13 16:04 UTC by Thomas Haller
Modified: 2016-04-14 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-04-13 16:04:25 UTC 
I noticed, that when I update a currently activated connection to rename it, the active-connection's ID gets out of sync.
That is fixed by commit
  "active-connection: update D-Bus properties of active-connection when set..."


While fixing that, I did some larger refactorings (because originally I wanted to solve the bug by having NMPolicy telling the active connection to re-sync. Only later I had NMActiveConnection directly subscribe to NM_SETTINGS_CONNECTION_UPDATED*.


so, the branch contains various cleanups, fixes and refactoring.


Please review.
Comment 1 Beniamino Galvani 2016-04-14 08:36:14 UTC 
LGTM.