After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764966 - oggdemux: Gaps when playing test sine wave VBR file
oggdemux: Gaps when playing test sine wave VBR file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-12 19:55 UTC by Carlos Rafael Giani
Modified: 2016-06-16 10:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ogg vorbis file that is played with a gap (123.75 KB, audio/ogg)
2016-04-12 19:55 UTC, Carlos Rafael Giani
  Details
fix audio glitches with low bitrate vorbis (1.48 KB, patch)
2016-04-14 13:05 UTC, Vincent Penquerc'h
committed Details | Review

Description Carlos Rafael Giani 2016-04-12 19:55:50 UTC
Created attachment 325821 [details]
ogg vorbis file that is played with a gap

When playing a test sine wave file, after ~2 seconds, a gap can be heard. This gap is caused by a gap event.

A git bisect reveals that commit 87fd62811d759bd2b6dfb22cf7638b2d70979560 "oggdemux: fix seeking in files with a "missing" stream" caused this. Prior to this commit, the file plays without any gaps. This commit was added as part of https://bugzilla.gnome.org/show_bug.cgi?id=745980 .

I am not sure if the file itself is broken or if this is a bug in oggdemux, but with VLC, ffplay, mplayer, the file plays fine. oggdec also decodes without a gap.
Comment 1 Vincent Penquerc'h 2016-04-14 13:05:11 UTC
Created attachment 325995 [details] [review]
fix audio glitches with low bitrate vorbis
Comment 2 Vincent Penquerc'h 2016-06-16 10:15:29 UTC
commit 2ac5bd293b16714085dc72ae23c4adf834c1db56
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Apr 14 14:02:27 2016 +0100

    oggdemux: fix audio glitches with low bitrate vorbis
    
    A low bitrate stream which can pack more than 2 seconds of audio
    in a page would cause the stream's position to be updated not
    often enough, and would trigger a spurious "jump" via a GAP
    event. Instead, we update the stream position after calculating
    the new overall segment position.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764966