GNOME Bugzilla – Bug 764857
[PATCH] Small theme improvements
Last modified: 2016-04-25 20:30:22 UTC
1. theme/Adwaita: Improve contrast of the notification bubbles This makes the text more readable. 2. theme/HighContrast: fix tray icon color HighContrast theme uses symbolic icons, but tray icons are invisible without setting a color for the images.
Created attachment 325675 [details] [review] theme/Adwaita: Improve contrast of the notification
Created attachment 325676 [details] [review] theme/HighContrast: fix tray icon color
Created attachment 325678 [details] [review] theme/HighContrast: use regular icons Unfortunately the second patch works only if I set the style from the inspector. I think the color is probably inherited from panel's system tray, but the opacity is configured to something random value. Maybe the alpha value is uninitialised in the panel?
It looks like the alpha value is uninitialized here, so we can't use symbolic icons until it's not fixed: https://git.gnome.org/browse/gtk+/tree/gtk/deprecated/gtktrayicon-x11.c#n550
I sent a patch for the gtk+ project, which fixes the problem with symbolic tray icons: https://bugzilla.gnome.org/show_bug.cgi?id=764863 Once it's merged, my second patch is no longer needed.
It looks very readable to me... Do we really need black text?
Now it looks good without my patch... I think that something is changed between gtk3 3.20.2 and 3.20.3. So I think that none of these patches are needed now. :)
Ok, then I will close this bug as fixed.