GNOME Bugzilla – Bug 764780
Add compatibility code for older cups
Last modified: 2016-04-08 14:18:50 UTC
Created attachment 325588 [details] [review] Add compatibility code for older cups Hiroshi Takekawa sent this patch by email to gnomecc-list@gnome.org > I'm rebuilding gnome suite since 3.20 has been released, and found > gnome-control-center cannot be built with older cups. > > Probably older cups become unsupported and you're not interested in this > patch. Though I created this patch for me anyway, so I'm trying to send > this for merge.
Review of attachment 325588 [details] [review]: Thank you for attaching the patch. It needs some tuning yet. ::: panels/printers/pp-cups.c @@ +29,3 @@ +#define ippGetState(ipp) ipp->state +#define ippGetStatusCode(ipp) ipp->request.status.status_code +#define ippGetString(attr, element, language) attr->values[element].string.text We don't need to have the ippGetState() and ippGetString() macros here. ::: panels/printers/pp-job.c @@ +23,3 @@ #include <gio/gio.h> #include <cups/cups.h> We have to add this here: #if (CUPS_VERSION_MAJOR > 1) || (CUPS_VERSION_MINOR > 5) #define HAVE_CUPS_1_6 1 #endif Otherwise it won't compile with current CUPS. @@ +29,3 @@ +#define ippGetInteger(attr, element) attr->values[element].integer +#define ippGetState(ipp) ipp->state +#define ippGetStatusCode(ipp) ipp->request.status.status_code We don't need to have the ippGetState() and ippGetStatusCode() macros here.
Created attachment 325590 [details] [review] Add compatibility code for older cups
Review of attachment 325590 [details] [review]: Thank you for the changes. It looks good.
Thanks for the review! .