GNOME Bugzilla – Bug 764602
Add GameFAQs source
Last modified: 2016-05-14 00:41:59 UTC
.
Created attachment 325355 [details] [review] lua-factory: Make resolve_keys type optional Lua sources should be able to not specify any specific resolve_keys type to support all the types, including the untyped ones.
Created attachment 325356 [details] [review] lua-factory: Add GameFAQs source To fetch metadata for games. Now that grilo core doesn't force a particular sub-type of media (video, audio or image), and given that the main user of this source will be gnome-games, it makes sense to ship this helper in grilo-plugins directly.
Note: - there's a few FIXMEs in the source, still - it might be better to allow the resolve_key types to be "something other than audio/video/photo" so that we can avoid trying to resolve films through this source.
Review of attachment 325356 [details] [review]: ::: src/lua-factory/sources/grl-gamefaqs.lua @@ +1,2 @@ +--[[ + * Copyright (C) 2014 Grilo Project Shouldn't it be 2016?
(In reply to Adrien Plazas from comment #4) > Review of attachment 325356 [details] [review] [review]: > > ::: src/lua-factory/sources/grl-gamefaqs.lua > @@ +1,2 @@ > +--[[ > + * Copyright (C) 2014 Grilo Project > > Shouldn't it be 2016? That's the only problem? Great :)
Created attachment 327578 [details] [review] Adds more MIME-types This should be merged with the previous commit.
Created attachment 327579 [details] [review] Adds more MIME-types This should be merged with the previous commit.
Created attachment 327636 [details] [review] lua-factory: Add "none" resolve_keys type Lua sources should be able to specify that they do not support any of the base types that grilo uses.
Created attachment 327637 [details] [review] lua-factory: Add GameFAQs source To fetch metadata for games. Now that grilo core doesn't force a particular sub-type of media (video, audio or image), and given that the main user of this source will be gnome-games, it makes sense to ship this helper in grilo-plugins directly. With help from Adrien Plazas <kekun.plazas@laposte.net>
Here are some comments when testing the source in Games: The covers are too small and end up being very blurry. WiiWare covers quality is so-so... Some PC-Engine games have a Virtual Console thumbnail, whose quality is so-so too. Searching "elix-smashit-pal" on SNES returned the wrong game. Searching "NIGHTS" on Saturn return Christmas NiGHTS which is wrong. Searching "Densetsu no Stafy" on GBA returned some Bomberman game which is wrong, the correct spelling is "Densetsu no Starfy" with an 'r'. Searching "Kirby & the Amazing Mirror" on GBA gave no result, searching on the website direclty give a good result and it converts the & in the URL as %26. Searching "KirbyReturnsToDreamland PAL" was not found on Wii because of the quality of the title. Searching "PANZER_DRAGOON_ZWEI" on Saturn gave no result, replacing '_' by a space gives a good result. Searching "Agony_Disk1" on Amiga gave no result, replacing '_' by a space gives a good result. Searching "Sonic CD" as a Genesis game returned "Sonic & Knuckles", both the system and the game are wrong.
(In reply to Adrien Plazas from comment #10) > Here are some comments when testing the source in Games: > > The covers are too small and end up being very blurry. We'll need to look into the "images" link to fetch the correct ones. > WiiWare covers quality is so-so... When we look into the images page, we can give you multiple choices for thumbnails, you'll need to present the choices to the user in a properties page I think. > Some PC-Engine games have a Virtual Console thumbnail, whose quality is > so-so too. Same as above. > Searching "elix-smashit-pal" on SNES returned the wrong game. I looked for "elix" and "smashit" on the SNES, found nothing. > Searching "NIGHTS" on Saturn return Christmas NiGHTS which is wrong. There's "nights into dreams..." and "christmas nights into dreams..." as returned by the web service. Looking for the former returns the expected game, see below. > Searching "Densetsu no Stafy" on GBA returned some Bomberman game which is > wrong, the correct spelling is "Densetsu no Starfy" with an 'r'. This is a case where you'd need a "properties" UI in games, with the ability to change the title, and force a cover search. The user with that same broken title would likely see a cover that didn't match, look on the internet, change the name of the game in games (or in the filesystem directly), and having a button there to force a search at that moment would probably be nice. > Searching "Kirby & the Amazing Mirror" on GBA gave no result, searching on > the website direclty give a good result and it converts the & in the URL as > %26. Fixed. > Searching "KirbyReturnsToDreamland PAL" was not found on Wii because of the > quality of the title. Another use case for the above "force cover search". > Searching "PANZER_DRAGOON_ZWEI" on Saturn gave no result, replacing '_' by a > space gives a good result. Fixed. > Searching "Agony_Disk1" on Amiga gave no result, replacing '_' by a space > gives a good result. Fixed as well. > Searching "Sonic CD" as a Genesis game returned "Sonic & Knuckles", both the > system and the game are wrong. It finds Sonic CD properly when searching under "Sega CD" as the console. There's no "Sonic CD" for the Megadrive, as it doesn't have a CD drive... Is this a mime-type problem?
From my side, the only TODO left is fetching the thumbnails from the image page instead of the game's page. This will require a little bit of work, as grilo allows us to check which metadata you requested. If you only requested the thumbnails, we wouldn't load the game's page, but straight to "URL/images" instead, reducing the number of requests for the case where you don't mind knowing the rating, publication date or description. You can likely make that call for description, etc. when you have a properties page for them.
Created attachment 327837 [details] [review] lua-factory: Add GameFAQs source To fetch metadata for games. Now that grilo core doesn't force a particular sub-type of media (video, audio or image), and given that the main user of this source will be gnome-games, it makes sense to ship this helper in grilo-plugins directly. With help from Adrien Plazas <kekun.plazas@laposte.net>
Created attachment 327838 [details] [review] lua-factory: Fix API doc for grl.get_requested_keys()
Attachment 327636 [details] pushed as 5e11fca - lua-factory: Add "none" resolve_keys type Attachment 327837 [details] pushed as fdbfd81 - lua-factory: Add GameFAQs source Attachment 327838 [details] pushed as fe24c93 - lua-factory: Fix API doc for grl.get_requested_keys()