After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764522 - gnome-builder-3.20 fails configure: please recompile a threadsafe version of libgit2 (-DTHREADSAFE:BOOL=ON)
gnome-builder-3.20 fails configure: please recompile a threadsafe version of ...
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-03 08:56 UTC by alpine.art.de
Modified: 2016-04-12 23:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
config.log (125.70 KB, text/x-log)
2016-04-03 08:56 UTC, alpine.art.de
  Details
build: fix test usage with logic condition in git plugin (1.16 KB, patch)
2016-04-12 11:24 UTC, Andreas Henriksson
committed Details | Review

Description alpine.art.de 2016-04-03 08:56:44 UTC
Created attachment 325251 [details]
config.log

libgit2 is compiled with THREADSAFE=ON. There seems to be an issue in the build system, the test program fails because of not finding an include file:

configure:11833: gcc -o conftest -g -O2 -std=gnu11 -D_GNU_SOURCE    conftest.c   >&5
conftest.c:33:33: fatal error: libgit2-glib/ggit.h: No such file or directory
   #include <libgit2-glib/ggit.h>

libgit2-glib/ggit.h obviously comes with libgit2-glib. There seem to be calls to pkg-config and also some changes to CFLAGS, but the needed -I-directive is missing.

Please tell me if you need more information.
Comment 1 Andreas Henriksson 2016-04-11 10:29:46 UTC
Ran into this myself and the entire message is quite misleading. It has nothing to do with threads or not, but that libgit2-glib was not found at all (ie. the required version, as specified in the git plugins configure file - not the main configure.ac, is not available)!
Comment 2 Andreas Henriksson 2016-04-12 11:24:48 UTC
Created attachment 325788 [details] [review]
build: fix test usage with logic condition in git plugin

Before having a new enough libgit2-glib I ran into the warning
about my libgit2-glib not being built properly with threads.
After having a new enough libgit2-glib when buildin I ran into
an infinite loop of "= no" lines being outputted...

This change should hopefully fix both.
Comment 3 Christian Hergert 2016-04-12 23:46:17 UTC
LGTM, thanks for fixing this!

Attachment 325788 [details] pushed as b9b852e - build: fix test usage with logic condition in git plugin