After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764504 - background: refactor code into separate function
background: refactor code into separate function
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-02 17:12 UTC by Cosimo Cecchi
Modified: 2016-04-05 04:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: refactor code into separate function (4.19 KB, patch)
2016-04-02 17:12 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-04-02 17:12:03 UTC 
Backport of a refactor from a downstream Endless patch; no functional change.
Comment 1 Cosimo Cecchi 2016-04-02 17:12:07 UTC 
Created attachment 325229 [details] [review]
background: refactor code into separate function

Split out the creation of a file monitor in a separate function.
Comment 2 Debarshi Ray 2016-04-04 10:01:11 UTC 
Review of attachment 325229 [details] [review]:

Thanks, Cosimo. Looks good to me.

We don't have a gnome-3-20 branch yet, so it might be better to wait. On the other hand it looks simple and safe enough to me, and it affects neither the strings nor the UI. Up to you.
Comment 3 Cosimo Cecchi 2016-04-05 04:50:00 UTC 
Thanks, I pushed this to master.

Attachment 325229 [details] pushed as a630474 - background: refactor code into separate function