GNOME Bugzilla – Bug 764445
authPrompt: PAM message wrap_line failed
Last modified: 2016-10-14 13:31:12 UTC
Issue is same with bgo#705037: We got warning message from pam which should be shown as multiple lines (then length of message is longer than entry of password entry of course). But we can see this message is shown just in one line and cut, ends up with "..." I'm sure we got the bgo#705037 involved(gnome 3.10) So I add following code into gnome-shell/js/gdm/authPrompt.js: this._message.clutter_text.ellipsize = Pango.EllipsizeMode.NONE; to make sure that we don't take ellipsize into consideration so that we can make line_wrap works. Although message are shown in two lines, I got wired characters in the second line. So I am wondering: Did we really solve the issue in bgo#705037? Thanks
Created attachment 325131 [details] wrap_line failed
(In reply to tyang from comment #1) > Created attachment 325131 [details] > wrap_line failed Please ignore this attachment,sorry
Created attachment 325203 [details] [review] make line-wrap work To make wrap-line work by setting clutter_text.line_wrap to true, we need to ensure that st-label has installed the property line-wrap already.Then we also need to set ellipsize to default.
committed it on github: https://github.com/GNOME/gnome-shell/pull/7
Created attachment 325476 [details] [review] patch for fixing wrap_line issue The point is we need to confirm that ellipsize is set to false ,so that we can truly make wrap_line happen, otherwise the ellipsize will have a higher priority than the wrap_line property in clutter_text. I wish this could be handled soon, so if you think this is correct, please let me know where I can push this patch to on github... PS1: This patch is based on gnome 3.10, so the changes in theme file should be omitted. PS2: You can reproduce the issue by changing the password when next time you try to log into the gnome, and set a password which is against the complexity of pam/AD. Thanks
*** Bug 745082 has been marked as a duplicate of this bug. ***
Created attachment 337554 [details] [review] Patch based on latest git code This patch is created with git://git.gnome.org/gnome-shell and with gnome-style commit message from https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines Thanks
Review of attachment 337554 [details] [review]: thanks. do you have commit access?
(In reply to Ray Strode [halfline] from comment #8) > Review of attachment 337554 [details] [review] [review]: > > thanks. do you have commit access? No, I don't how can I get the access to that? Thanks
well for now I'll just push it myself. If you keep doing patches though, we can get you access to make pushing easier.
Thanks much !