GNOME Bugzilla – Bug 764145
[review] lr/gnome-developer: make developer.gnome.org/NetworkManager less unpleasant
Last modified: 2016-03-29 12:44:17 UTC
Now: https://developer.gnome.org/NetworkManager/1.1/ With changes: https://people.freedesktop.org/~lkundrak/nm-docs/
>> dbus: build docbook when generating the code ifcfg-rh-com.redhat and dispatcher interface are internal, private D-Bus APIs. Nobody is supposed to use them, except initscripts and dispatcher, respectively. Let's not generate them. dcbw said he likes to keep the CHANGELOG file. Me personally, I dislike it because a git-grep usually has results from the CHANGELOG in which I am not interested. About the rest I am not familiar with this. But looks all right.
Some command listings in the nmcli-examples output page contain HTML tags. Apart from that, looks good to me.
Seems that there are some issues with the gtkdoc conversion of netsted <example><programlisting><emphasis> tags. In nmcli-examples.xml more recent examples take advantage of the <synopsis> tag instead of the <programlisting> one. The output in the man page should be the same... so, when dealing with sample commands, why not use always the <synopsis> tag? Attaching s{i,a}mple patch. Anyway, nm-docs restyling looks much better to me :-)
Created attachment 324781 [details] [review] programlisting --> synopsis
Merged with Beniamino's patch.
(In reply to Lubomir Rintel from comment #5) > Merged with Beniamino's patch. Actually it was Francesco's one :)