After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764092 - gstrfuncs: Document the behaviour of g_strjoinv()
gstrfuncs: Document the behaviour of g_strjoinv()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-03-23 17:26 UTC by Bastien Nocera
Modified: 2016-04-04 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstrfuncs: Document the behaviour of g_strjoinv() (1.07 KB, patch)
2016-03-23 17:26 UTC, Bastien Nocera 		none Details | Review
gstrfuncs: Document the behaviour of g_strjoinv() (1.04 KB, patch)
2016-03-23 20:38 UTC, Bastien Nocera 		committed Details | Review
gstrfuncs: Add test for g_strjoinv() behaviour (1.25 KB, patch)
2016-03-23 20:38 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-03-23 17:26:03 UTC 
.
Comment 1 Bastien Nocera 2016-03-23 17:26:07 UTC 
Created attachment 324606 [details] [review]
gstrfuncs: Document the behaviour of g_strjoinv()

The behaviour of g_strjoinv() isn't explicitely explained when the array
is NULL, or contains less than 2 items. This removes the guesswork.
Comment 2 Matthias Clasen 2016-03-23 17:35:30 UTC 
Review of attachment 324606 [details] [review]:

sure, that seems fine. It would be even greater if you added tests to ensure we preserve these corner cases.
Comment 3 Bastien Nocera 2016-03-23 20:38:00 UTC 
Created attachment 324623 [details] [review]
gstrfuncs: Document the behaviour of g_strjoinv()

The behaviour of g_strjoinv() isn't explicitely explained when the array
contains less than 2 items. This removes the guesswork.
Comment 4 Bastien Nocera 2016-03-23 20:38:08 UTC 
Created attachment 324624 [details] [review]
gstrfuncs: Add test for g_strjoinv() behaviour
Comment 5 Bastien Nocera 2016-03-23 20:45:19 UTC 
(In reply to Bastien Nocera from comment #1)
> Created attachment 324606 [details] [review] [review]
> gstrfuncs: Document the behaviour of g_strjoinv()
> 
> The behaviour of g_strjoinv() isn't explicitely explained when the array
> is NULL, or contains less than 2 items. This removes the guesswork.

Can't actually pass NULL as the array, duh!
Comment 6 Bastien Nocera 2016-04-04 13:10:05 UTC 
Attachment 324623 [details] pushed as 283c565 - gstrfuncs: Document the behaviour of g_strjoinv()
Attachment 324624 [details] pushed as 21ad4c8 - gstrfuncs: Add test for g_strjoinv() behaviour