After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 764056 - ostree doesn't build without libarchive
ostree doesn't build without libarchive
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-23 08:36 UTC by Stef Walter
Modified: 2016-03-23 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix building without libarchive (2.11 KB, patch)
2016-03-23 08:36 UTC, Stef Walter 		reviewed Details | Review

Description Stef Walter 2016-03-23 08:36:33 UTC 
Although libarchive is an optional build option, the build fails without it.
Comment 1 Stef Walter 2016-03-23 08:36:46 UTC 
Created attachment 324572 [details] [review]
Fix building without libarchive

Although libarchive is an optional build option, the build
fails without it.
Comment 2 Colin Walters 2016-03-23 17:36:05 UTC 
Review of attachment 324572 [details] [review]:

Thanks for the patch; unfortunately it's a bit harder than this because the -archive.c file also contains API stubs for the non-libarchive code path.  In other words the intention is to have one ABI regardless of compile time options - if built without libarchive they just turn into errors.

Surprisingly, having nonexistent symbols in -Wl,--version-script doesn't break the build.  How is that not an error?
Comment 3 Colin Walters 2016-03-23 17:58:15 UTC 
Are you doing this because you actually want a version without libarchive, or because you just happened to not have the dep installed and the build failed?

Anyways, reworked and pushed:
https://git.gnome.org/browse/ostree/commit/?id=2454957e8dff9a88e5d6c10df15dec161277cc0a