GNOME Bugzilla – Bug 764001
Depends on gnome-shell for org.gnome.shell.calendar
Last modified: 2017-04-17 18:20:40 UTC
Since 32c5c824e326759af0766b011b02f354889a7b6c, gnome-calendar now depends on having this schema installed. For Ubuntu we have Unity instead of Shell, and so we don't have it. Would you accept a patch to make this conditional (and assume FALSE if it's not there, presumably)? Another option would be to move this schema out to gsettings-desktop-schemas or something, but I'm not familiar with that project to know if that is appropriate. I guess that an org.gnome.shell schema wouldn't be wanted there, so we'd have to migrate to a new name.
It'd be nice if we could move this setting to the default desktop-schemas repository, so we don't have to check for the environment. If that doesn't happen, I'm cautiously positive in accepting a patch that checks if the desktop environment is GNOME.
You'd rather that than making it a soft depends - i.e. checking if the schema is installed and doing something sensible if not? That's sort of the same as checking if you're in GNOME using XDG_CURRENT_DESKTOP or similar, but feels a bit more graceful to me. Will check about g-d-s first. (but not for a couple of weeks - on holiday atm; cheers!)
This also breaks running Calendar from xdg-app - due to the missing schema latest master crashes with: '(gnome-calendar:2): GLib-GIO-ERROR **: Settings schema 'org.gnome.shell.calendar' is not installed'
I would say that it is a bug for applications to use schemas that are not a) their own or b) part of gsettings-desktop-schemas. If you want a desktop wide setting for this, that requires patches for gsettings-desktop-schemas and gnome-shell *before* using it in your app.
This is also breaking the 3.20 stable xdg-app of gnome-calendar.
Created attachment 327692 [details] [review] year-view: Use the new schema from gsettings-desktop-schemas So that we don't have to depend on GNOME shell. -- Here's the patch to use gsettings-desktop-schemas schema for your consideration. I don't know how to best depend on the gsettings-desktop-schemas version. Is it just implicit? The depdendent bugs need to be fixed before this one.
(In reply to Iain Lane from comment #6) > I don't know how to best depend on the gsettings-desktop-schemas version. Is > it > just implicit? It's not. gsettings-desktop-schemas has a pkg-config file.
(In reply to Bastien Nocera from comment #7) > (In reply to Iain Lane from comment #6) > > I don't know how to best depend on the gsettings-desktop-schemas version. Is > > it > > just implicit? > > It's not. gsettings-desktop-schemas has a pkg-config file. Yep. That's build-time only, but the best we can do I suppose.
(In reply to Iain Lane from comment #8) > (In reply to Bastien Nocera from comment #7) > > (In reply to Iain Lane from comment #6) > > > I don't know how to best depend on the gsettings-desktop-schemas version. Is > > > it > > > just implicit? > > > > It's not. gsettings-desktop-schemas has a pkg-config file. > > Yep. That's build-time only, but the best we can do I suppose. The application will assert when it's not installed. A simple sanity check would cover that.
Created attachment 327694 [details] [review] year-view: Use the new schema from gsettings-desktop-schemas So that we don't have to depend on GNOME shell.
Review of attachment 327694 [details] [review]: LGTM. I'll apply and push this patch once GNOME Settings Daemon lands the new setting. Thanks for working on that!
(In reply to Georges Basile Stavracas Neto from comment #11) > Review of attachment 327694 [details] [review] [review]: > > LGTM. I'll apply and push this patch once GNOME Settings Daemon lands the > new setting. Thanks for working on that! There's no settings in gnome-settings-daemon.
(In reply to Bastien Nocera from comment #12) > There's no settings in gnome-settings-daemon. Ops! I meant to say gsettings-desktop-schemas.
Thanks everyone who was involved in this, specially Iain. Attachment 327694 [details] pushed as 9b358eb - year-view: Use the new schema from gsettings-desktop-schemas