After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763927 - make-w32.sh does uses the same renders for L and XL variants
make-w32.sh does uses the same renders for L and XL variants
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-19 23:05 UTC by LRN
Modified: 2016-03-20 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix make-w32.sh to actually use L and XL images (8.45 KB, patch)
2016-03-19 23:05 UTC, LRN 		committed Details | Review

Description LRN 2016-03-19 23:05:01 UTC 
Adwaita-Large and Adwaita-ExtraLarge are made, but they use
the same .in files as the normal Adwaita theme, and end up
looking identical.
Comment 1 LRN 2016-03-19 23:05:07 UTC 
Created attachment 324350 [details] [review]
Fix make-w32.sh to actually use L and XL images

The last step, to call anicursorgen.py and make the actual
.cur and .ani files misses the crucial element - it does not
pick different .in files depending on which theme it generates.
Without that the Adwaita-Large and Adwaita-ExtraLarge are just
copies of Adwaita cursor theme.
Comment 2 LRN 2016-03-19 23:09:48 UTC 
Attachment 324350 [details] is not a proper fix because it always tries to build Adwaita, Adwaita-Large and Adwaita-ExtraLarge, even if the user did not wish these themes to be built.

Note how toplevel Makefile.am does a dance with ENABLE_L_XL_VARIANTS and $(enable_l_xl_variants). make-w32.sh should be something similar (which most likely means it becoming make-w32.sh.in and being post-processed).

Or maybe just have make-w32.sh and make-w32-l-xl.sh.
Or make it an argument (make-w32.sh is invoked by the person packaging adwaita-icon-theme explicitly, outside of the configure/make mechanisms, during package reconfiguration).

3.20 is close, and i don't have the time to fix it properly, sorry.
Comment 3 Jakub Steiner 2016-03-20 09:45:01 UTC 
Attachment 324350 [details] pushed as 41f47a4 - Fix make-w32.sh to actually use L and XL images