GNOME Bugzilla – Bug 763888
[PATCH] Add Command applet
Last modified: 2016-03-21 20:26:55 UTC
Created attachment 324296 [details] [review] Add Command applet It's a new applet originally developed for MATE Panel. Original source: http://git.mate-desktop.org/mate-applets/tree/command
I am not license expert, but: GNOME Applets - GNU General Public License, version 2 or any later version; Your patch - GNU General Public License, version 3 or any later version; When we merged window-picker applet, Sebastian asked for permission to "downgrade" license: https://github.com/lanoxx/window-picker-applet/commit/c9738bab0777a1da4feda8f25cd53c1cb0710c71 So you will need to ask author if he allows to use his code under GPLv2 or later, probably by adding comment here. Then update patch to also include bug url. Same thing with your patch in 763889 bug.
Ah, I see. I opened a new issue in their bug tracker: https://github.com/mate-desktop/mate-applets/issues/183
Created attachment 324368 [details] [review] Add Command applet v2 The original author agreed to re-license Command and Timer applets under GPL-2+: https://github.com/mate-desktop/mate-applets/issues/183#issuecomment-198745034
Both applets use deprecated GtkTable, can you port to GtkGrid?
Created attachment 324502 [details] [review] command, timerapplet: port from GtkTable to GtkGrid Done, see the attachment. Tested and works for me.
Review of attachment 324502 [details] [review]: Thanks!