GNOME Bugzilla – Bug 763857
debug-viewer: add options to filter in instead of only out
Last modified: 2016-04-04 20:32:14 UTC
I have patches to enable filtering in instead of filtering out only.
Created attachment 324245 [details] [review] Added support in filters for filtering in
Created attachment 324246 [details] [review] Add options to menus
I think you should feel free to just push that after a while if no one objects, I don't think anyone is working actively on the debug viewer at the moment.
Ignore the previous comment, I'll push it in a bit if no one has any comments, it looks fine to me at first glance.
Comment on attachment 324246 [details] [review] Add options to menus Setting to accepted-commit_after_freeze as reminder.
Can we get my gtk+3 port working before we change the gtk+2 version? https://github.com/ensonic/gst-devtools/tree/debug-viewer-gtk3
> Can we get my gtk+3 port working before we change the gtk+2 version? > https://github.com/ensonic/gst-devtools/tree/debug-viewer-gtk3 That's partly why I CC-ed you :) What's the status with that? Anything in particular you need help with? Or does it just need merging or .. ?
As I wrote on the mailing list, it is slow. Probably a mix of regressions in gtk+2 -> gtk+3 and python-gobject -> py-gi. But I am running our of ideas. I had posted the mail with the git branch in the hope that people would try it and maybe have some ideas how to profile this.
Is performance unbearably slow? If it's usable I'd just merge it :)
Unfortunately so slow that you'd suspect a bug and kill it before it is ready loading a log :/ I'll talk to the gi guys.
I've just rebased the branch and tested it a bit more. For a 15M log file it is kind of okay. I'd loved to get some feedback from other whether the performance is okayish enough to merge it. We'll probably find some more bug when using it, since this is python. Xabier, can you please give my branch a spin? And thanks for making these changes, I'd love to see them added and I think the patches will still apply easily on the branch.
(In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #11) > I've just rebased the branch and tested it a bit more. For a 15M log file it > is kind of okay. I'd loved to get some feedback from other whether the > performance is okayish enough to merge it. > > Xabier, can you please give my branch a spin? And thanks for making these > changes, I'd love to see them added and I think the patches will still apply > easily on the branch. I just did. My patches apply against your branch. About the performance, it is true that running your branch takes aproximately 4 times (about 10s) to load a 87MB file against the original (about 2,5s). I am using my own branch so I am not in a hurry to land the patches, but I think it is safe and you wouldn't have any issues if you had to rebase with them included.
Created attachment 324877 [details] [review] Added support in filters for filtering in
Created attachment 324878 [details] [review] Add options to menus I updated the patches to add a new filter, a log level and all above a certain one.
The following fixes have been pushed: 82910a1 Added menu opts to filter in instead of only out ba4afd7 Added support to filter in instead of only out
Created attachment 325381 [details] [review] Added menu opts to filter in instead of only out Added also menu option to filter a log level and all above that
Created attachment 325382 [details] [review] Added support to filter in instead of only out Added support to filter a log level and all above it
Thanks! Merged.