After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763836 - Sub-screens (edit, activate, etc) only offer "Quit" option and don't allow return to previous menu
Sub-screens (edit, activate, etc) only offer "Quit" option and don't allow re...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmtui
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2016-03-17 20:32 UTC by Dan Williams
Modified: 2016-04-15 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tui: return to initial menu after sub-forms exit (3.37 KB, patch)
2016-04-08 12:48 UTC, Beniamino Galvani 		none Details | Review
[PATCH] fixup! tui: return to initial menu after sub-forms exit (7.08 KB, patch)
2016-04-15 07:45 UTC, Beniamino Galvani 		none Details | Review

Description Dan Williams 2016-03-17 20:32:06 UTC 
With nmtui if you want to edit a connection and then activate it on a device, you must first edit the connection, then choose the only option "Quit", then re-launch nmtui and activate the connection.  This sucks.
Comment 1 Beniamino Galvani 2016-04-08 12:48:05 UTC 
Created attachment 325587 [details] [review]
tui: return to initial menu after sub-forms exit
Comment 2 Thomas Haller 2016-04-14 16:18:00 UTC 
Looks good, also, when you start "nmtui-subcommand", then <Quit> will still quit completely (good).


But maybe, now the button to go back should not be called "Quit" anymore, but back?
Comment 3 Dan Williams 2016-04-14 16:19:32 UTC 
Yeah, changing the button name if it's started through "nmtui" would be good.
Comment 4 Dan Williams 2016-04-14 16:24:07 UTC 
Patch LGTM though.
Comment 5 Beniamino Galvani 2016-04-15 07:45:42 UTC 
Created attachment 326068 [details] [review]
[PATCH] fixup! tui: return to initial menu after sub-forms exit

(In reply to Thomas Haller from comment #2)
> 
> But maybe, now the button to go back should not be called "Quit" anymore,
> but back?

Right, how about this fixup?
Comment 6 Thomas Haller 2016-04-15 09:22:50 UTC 
Code looks good, I assume it is right (didn't test it).

ACK