GNOME Bugzilla – Bug 763801
queue2: typo in out rate calculation
Last modified: 2017-11-23 17:12:13 UTC
In my platform I was facing below 2 issues while plying 4K mkv stream using http 1. queue2 is consuming more and more memory. 2. while running, I encounter frequent pauses due to buffering While investigation I found that in gstqueue2.c/update_out_rate() byte_in_rate was used instead of byte_out_rate. On correcting this typo, above 2 issue are resolved. Thanks, Chandra
Created attachment 324162 [details] [review] queue2: fixed typo in out rate calculation
Thanks for your patch. It seems like this code is intentionally like it is though, as discussed on IRC: <wtay> the level in the queue is based on the input rate <wtay> not ever the output rate <wtay> the output rate is there for the query only Can you check why and where queue2 is consuming more and more memory for you? Where the memory piles up? Does your queue2 have any of the max-* properties set to 0? Are you running it in ringbuffer mode, temp-template mode, or use-buffering mode?
Thanks for quick reply. My queue2 have one non-zero max-* property and rest are set to 0 max-size-buffer=0 max-size-bytes=0 max-size-time=500000000 use-buffering=TRUE I am investigating at my side why this patch is resolving my scenario? Can you please inform me if above queue2 properties are ok?
Does your input to the queue2 have correct timestamps?
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment. Thanks!
*** Bug 758891 has been marked as a duplicate of this bug. ***