After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763758 - Do not use fixed values for widgets size in foreign drawing demo
Do not use fixed values for widgets size in foreign drawing demo
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-16 15:02 UTC by Carlos Garcia Campos
Modified: 2016-03-21 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (43.52 KB, patch)
2016-03-16 15:03 UTC, Carlos Garcia Campos 		needs-work Details | Review
And this is how it looks (18.70 KB, image/png)
2016-03-16 15:04 UTC, Carlos Garcia Campos 		  Details
Updated patch (43.52 KB, patch)
2016-03-18 08:15 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch (43.95 KB, patch)
2016-03-21 07:23 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2016-03-16 15:02:31 UTC 
It makes all icons blurry (check and radio buttons, spin buttons, arrows, etc.). And the result doesn't look like real widgets.
Comment 1 Carlos Garcia Campos 2016-03-16 15:03:52 UTC 
Created attachment 324108 [details] [review]
Patch

I've reworked the demo to use the sizes from the theme. I've also added a scale.
Comment 2 Carlos Garcia Campos 2016-03-16 15:04:19 UTC 
Created attachment 324109 [details]
And this is how it looks
Comment 3 Matthias Clasen 2016-03-16 15:09:48 UTC 
Review of attachment 324108 [details] [review]:

You should update the description of the demo at the top of the .c file. Currently, it says that the demo does _not_ show how to do sizing properly. You're trying to fix that here...
Comment 4 Carlos Garcia Campos 2016-03-16 15:34:35 UTC 
(In reply to Matthias Clasen from comment #3)
> Review of attachment 324108 [details] [review] [review]:
> 
> You should update the description of the demo at the top of the .c file.
> Currently, it says that the demo does _not_ show how to do sizing properly.
> You're trying to fix that here...

Ah, sure, I missed that comment.
Comment 5 Carlos Garcia Campos 2016-03-18 08:15:04 UTC 
Created attachment 324236 [details] [review]
Updated patch

Just updated the comment.
Comment 6 Matthias Clasen 2016-03-21 01:56:28 UTC 
Review of attachment 324236 [details] [review]:

seems to be the same patch ?
Comment 7 Carlos Garcia Campos 2016-03-21 07:22:37 UTC 
(In reply to Matthias Clasen from comment #6)
> Review of attachment 324236 [details] [review] [review]:
> 
> seems to be the same patch ?

Indeed, I don't know what happened, let me submit it again.
Comment 8 Carlos Garcia Campos 2016-03-21 07:23:03 UTC 
Created attachment 324413 [details] [review]
Updated patch