After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763731 - Return GTK_PRINT_OPERATION_RESULT_ERROR even if error == NULL
Return GTK_PRINT_OPERATION_RESULT_ERROR even if error == NULL
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.19.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-16 01:11 UTC by Debarshi Ray
Modified: 2016-03-21 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
print-operation: Be more robust in the error path (1.21 KB, patch)
2016-03-16 01:21 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-03-16 01:11:34 UTC 
gtk_print_operation_run can be passed a GError **, or one can pass NULL and call gtk_print_operation_get_error later to get the error. We should still return GTK_PRINT_OPERATION_RESULT_ERROR in case of an error if the caller opts for the latter.
Comment 1 Debarshi Ray 2016-03-16 01:21:04 UTC 
Created attachment 324069 [details] [review]
print-operation: Be more robust in the error path
Comment 2 Matthias Clasen 2016-03-16 02:55:18 UTC 
Review of attachment 324069 [details] [review]:

Looks right
Comment 3 Debarshi Ray 2016-03-21 15:11:57 UTC 
Comment on attachment 324069 [details] [review]
print-operation: Be more robust in the error path

Pushed to master after the 3.20.0 release.