After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763515 - Few minor clean-ups
Few minor clean-ups
Status: RESOLVED FIXED
Product: libsigc++
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsigc++ maintainer(s)
libsigc++ maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-11 22:00 UTC by Marcin Kolny (IRC: loganek)
Modified: 2016-03-18 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-build-remove-unused-m4-file.patch (3.07 KB, patch)
2016-03-11 22:00 UTC, Marcin Kolny (IRC: loganek) 		none Details | Review
0002-.gitignore-update-test-ignored-files-list.patch (859 bytes, patch)
2016-03-11 22:00 UTC, Marcin Kolny (IRC: loganek) 		none Details | Review

Description Marcin Kolny (IRC: loganek) 2016-03-11 22:00:06 UTC 
Created attachment 323735 [details] [review]
0001-build-remove-unused-m4-file.patch

Please review.
Comment 1 Marcin Kolny (IRC: loganek) 2016-03-11 22:00:31 UTC 
Created attachment 323736 [details] [review]
0002-.gitignore-update-test-ignored-files-list.patch
Comment 2 Kjell Ahlstedt 2016-03-17 09:38:12 UTC 
Both patches look fine, except that now

  -dist_noinst_DATA = $(sigc_m4)

in sigc++/Makefile.am shall be

  -dist_noinst_DATA = $(sigc_m4) CMakeLists.txt
  +dist_noinst_DATA = CMakeLists.txt

I wonder if these lines in configure.ac can also be removed in libsigc++-3.0:

  AC_ARG_VAR([M4], [M4 macro processor command])
  AC_CHECK_PROGS([M4], [gm4 m4])
  AS_IF([test "x$M4" = x],
      [AC_MSG_FAILURE([[The GNU M4 macro processor is required for building libsigc++.]])])

Murray, comments?
Comment 3 Murray Cumming 2016-03-18 09:10:24 UTC 
Thanks. I've pushed the patches and that configure.ac change too.