After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763367 - video-player background is transparent black
video-player background is transparent black
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2016-03-09 10:43 UTC by Jonny Lamb
Modified: 2016-03-11 01:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video-player: ensure background is opaque black (941 bytes, patch)
2016-03-09 10:43 UTC, Jonny Lamb 		none Details | Review
video-player: ensure background is opaque black (take two) (941 bytes, patch)
2016-03-10 17:09 UTC, Jonny Lamb 		committed Details | Review

Description Jonny Lamb 2016-03-09 10:43:14 UTC 
Created attachment 323496 [details] [review]
video-player: ensure background is opaque black

...and should be opaque black.

I previously blindly opened a pull request on GitHub (https://github.com/GNOME/clutter-gst/pull/1) forgetting that Clutter was on GNOME infrastructure nowadays.
Comment 1 Lionel Landwerlin 2016-03-09 16:19:11 UTC 
Review of attachment 323496 [details] [review]:

::: examples/video-player.c
@@ +432,3 @@
   GstIterator         *iter;
   ClutterActor        *stage;
+  ClutterColor         stage_color = { 0xff, 0xff, 0xff, 0x00 };

Hmm... That would make it transparent white.
Is there an actual reason you want to change this? Or you not able to see the video maybe?
Comment 2 Jonny Lamb 2016-03-10 17:09:55 UTC 
Created attachment 323652 [details] [review]
video-player: ensure background is opaque black (take two)

(In reply to Lionel Landwerlin from comment #1)
> Hmm... That would make it transparent white.

Wow I must've written that while asleep.

> Is there an actual reason you want to change this?

On platforms that use an actual rgba surface (not intel without calling some extra function or something) it appears as transparent and looks weird.

If you want to keep it transparent go ahead and WONTFIX this. I hit this in tcmmd (https://github.com/alban/tcmmd/pull/3) and thought I'd push the same commit here as it's clearly where tcdemo originall came from.
Comment 3 Lionel Landwerlin 2016-03-10 17:18:17 UTC 
Review of attachment 323652 [details] [review]:

Looks good.
Comment 4 Lionel Landwerlin 2016-03-11 01:07:32 UTC 
Review of attachment 323652 [details] [review]:

Pushed to 3.0 branch.