After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763121 - vaapidecoder_h264/5: leaks when parsing fails
vaapidecoder_h264/5: leaks when parsing fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-04 23:25 UTC by Thiago Sousa Santos
Modified: 2016-03-09 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapidecoder_h264: plug leak of h264 parsing info (1.50 KB, patch)
2016-03-04 23:25 UTC, Thiago Sousa Santos 		committed Details | Review
vaapidecoder_h265: plug leak of h265 parsing info (1.59 KB, patch)
2016-03-04 23:25 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2016-03-04 23:25:20 UTC 
Seems like h264 and h265 parsers leak when something goes wrong in parsing.

Patches to follow.
Comment 1 Thiago Sousa Santos 2016-03-04 23:25:43 UTC 
Created attachment 323132 [details] [review]
vaapidecoder_h264: plug leak of h264 parsing info

If something goes wrong while parsing, the info object is
being leaked
Comment 2 Thiago Sousa Santos 2016-03-04 23:25:49 UTC 
Created attachment 323133 [details] [review]
vaapidecoder_h265: plug leak of h265 parsing info

If something goes wrong while parsing, the info object is
being leaked
Comment 3 Thiago Sousa Santos 2016-03-04 23:27:13 UTC 
I was only able to test the h264 patch as I don't have any faulty h265 streams here.
Comment 4 sreerenj 2016-03-05 19:22:32 UTC 
Patches lgtm,,, push for 1.8 ??
Comment 5 Sebastian Dröge (slomo) 2016-03-06 08:00:20 UTC 
Your decision :)
Comment 6 sreerenj 2016-03-06 09:55:54 UTC 
(In reply to Sebastian Dröge (slomo) from comment #5)
> Your decision :)

After 1.8 then :)
Comment 7 Víctor Manuel Jáquez Leal 2016-03-09 17:17:05 UTC 
Attachment 323132 [details] pushed as 2b47bf8 - vaapidecoder_h264: plug leak of h264 parsing info
Attachment 323133 [details] pushed as 0a9161a - vaapidecoder_h265: plug leak of h265 parsing info