After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763093 - udpsrc: Fix multicast group joining with provided sockets on Windows
udpsrc: Fix multicast group joining with provided sockets on Windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal blocker
: 1.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
1.6.4
Depends on:
Blocks:
 
 
Reported: 2016-03-04 12:12 UTC by Sebastian Dröge (slomo)
Modified: 2016-04-14 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
udpsrc: Fix multicast group joining with provided sockets on Windows (2.22 KB, patch)
2016-03-04 12:12 UTC, Sebastian Dröge (slomo) 		none Details | Review
udpsrc: Fix multicast group joining with provided sockets on Windows (2.47 KB, patch)
2016-03-04 13:33 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-03-04 12:12:27 UTC 
See commit message. This breaks gst-rtsp-server working in multicast mode
on Windows.
Comment 1 Sebastian Dröge (slomo) 2016-03-04 12:12:32 UTC 
Created attachment 323081 [details] [review]
udpsrc: Fix multicast group joining with provided sockets on Windows

On Windows the socket will be bound to ANY instead of the multicast group,
as binding to a multicast group does not work. Which would mean that we
override src->addr to become ANY and won't automatically join a multicast
group anymore on Windows.

On Linux we would automatically join a multicast group, keep it consistent.
Comment 2 Sebastian Dröge (slomo) 2016-03-04 13:33:45 UTC 
Created attachment 323084 [details] [review]
udpsrc: Fix multicast group joining with provided sockets on Windows

On Windows the socket will be bound to ANY instead of the multicast group,
as binding to a multicast group does not work. Which would mean that we
override src->addr to become ANY and won't automatically join a multicast
group anymore on Windows.

On Linux we would automatically join a multicast group, keep it consistent.
Comment 3 Sebastian Dröge (slomo) 2016-03-05 08:55:38 UTC 
Attachment 323084 [details] pushed as 49be64e - udpsrc: Fix multicast group joining with provided sockets on Windows