After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763045 - glmemoryallocator: Buffer size miss-match when mapping GLMemory without PBO
glmemoryallocator: Buffer size miss-match when mapping GLMemory without PBO
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.7.90
Other Linux
: Normal blocker
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 758852 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-03-03 15:28 UTC by Nicolas Dufresne (ndufresne)
Modified: 2016-03-11 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glbasememory: Don't change maxsize at run-time (1.76 KB, patch)
2016-03-04 00:51 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2016-03-03 15:28:13 UTC
I'm running on an old Nvidia card without PBO support. In that case, there is something wrong with the video alignment, and mapping the memory from avviddec fails.

 "subclass map fail"

Digging further, it seems to fail a size check (size > mem->maxsize) in the CPU access routine. That is likely a bug in the video alignment handling, as the delta is bring size to a multiple of 32. This is a regression from 1.6 I believe.
Comment 1 Nicolas Dufresne (ndufresne) 2016-03-04 00:51:24 UTC
Created attachment 323044 [details] [review]
glbasememory: Don't change maxsize at run-time

Maxsize is initialized once and should never change. Allocating data
should have no impact on the selected max size for this memory. This
causing memory map failure as the maxsize would become smaller then
size. This happened when using direct rendering in avviddec on GL that
does not support PBO transfer.
Comment 2 Nicolas Dufresne (ndufresne) 2016-03-04 01:04:44 UTC
Attachment 323044 [details] pushed as 140815f - glbasememory: Don't change maxsize at run-time
Comment 3 Nicolas Dufresne (ndufresne) 2016-03-04 01:05:16 UTC
Thanks for the review !
Comment 4 Matthew Waters (ystreet00) 2016-03-06 08:40:40 UTC
*** Bug 758852 has been marked as a duplicate of this bug. ***