After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763039 - [review] handle non UTF-8 characters during import and in filenames [th/utf8safe-bgo763039]
[review] handle non UTF-8 characters during import and in filenames [th/utf8s...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: 762962
 
 
Reported: 2016-03-03 12:16 UTC by Thomas Haller
Modified: 2016-03-08 09:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-03-03 12:16:58 UTC 
Based on https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00011.html, here a patches to handle non-UTF-8 encodings for Openvpn configuration differently.

Please review.
Comment 1 Thomas Haller 2016-03-03 12:31:19 UTC 
with respect to the properties dialog, utf8safe properties are not yet properly handled.

Note that this only matters if a property actually contains '\\' or non-UTF-8 chars.

For NM_OPENVPN_KEY_DEV, I think there is nothing to do. From the UI point of view, the escaped string is displayed as UTF-8 back and forth. It's only a problem, if the user enters one signle '\\', without being aware that he does escaping.


For the filenames it would involve extra work, because we must check that we properly escape/unescape as we interact with the filechooser.
Comment 2 Dan Williams 2016-03-07 23:17:15 UTC 
latest branch looks OK to me.