After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763002 - Navigate between pages by arrow key even if not in "Best Fit" mode
Navigate between pages by arrow key even if not in "Best Fit" mode
Status: RESOLVED DUPLICATE of bug 562257
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-03-02 18:15 UTC by Christoph Doepmann
Modified: 2016-04-14 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch against git master (1.42 KB, patch)
2016-03-02 18:15 UTC, Christoph Doepmann
none Details | Review

Description Christoph Doepmann 2016-03-02 18:15:59 UTC
Created attachment 322899 [details] [review]
proposed patch against git master

I was bothered by the fact that the arrow keys only have an effect of changing the page when the view is in "Best Fit" mode. I found this to be too restrictive. For instance, consider the common use case of viewing PDF presentation slides. If not having zoomed in and not having a very small window, it's likely that each slide will be displayed as a whole without any in-page scrolling. However, if you're not in "Best Fit" mode, you won't be able to go to the next slide using the right arrow key.

Therefore, I put together a small patch that extends the conditions on which an arrow key press will trigger changing pages. It basicly checks if the respective arrow key would be useful for in-page scrolling. If not (e.g. the whole x-dimension is shown, there is no scroll bar), evince will turn the page instead of ignoring the key press.

Any thoughts?
Comment 1 Christoph Doepmann 2016-04-14 08:49:38 UTC
Is there anything I could help with in working towards merging or improving the proposed patch?
Comment 2 Jason Crain 2016-04-14 14:57:19 UTC
This looks a bit like Marek's patch in bug 562257, so I recommend marking this as a duplicate and continuing any discussion there.
Comment 3 Germán Poo-Caamaño 2016-04-14 15:38:02 UTC
Thanks for taking the time to report this and submitting a patch. Please, help us to review the other patches and/or submit them in bug 562257.

*** This bug has been marked as a duplicate of bug 562257 ***