After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762962 - test-suite failure in test-import-export and test-import-export-glib
test-suite failure in test-import-export and test-import-export-glib
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
git master
Other Linux
: Normal normal
: ---
Assigned To: Thomas Haller
NetworkManager maintainer(s)
Depends on: 763039
Blocks: nm-1-2
 
 
Reported: 2016-03-02 01:44 UTC by Michael Biebl
Modified: 2016-03-11 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Biebl 2016-03-02 01:44:25 UTC 
Version: 1.1.91

After upgrading from 1.1.90 to 1.1.90, the test-suite fails:

FAIL: test-import-export
========================

/ovpn/properties/test_password_import: OK
/ovpn/properties/test_password_export: OK
/ovpn/properties/test_tls_import: OK
/ovpn/properties/test_tls_inline_import: OK
/ovpn/properties/test_tls_export: OK
/ovpn/properties/test_pkcs12_import: OK
/ovpn/properties/test_pkcs12_export: OK
/ovpn/properties/test_non_utf8_import: **
ERROR:test-import-export.c:86:_check_item: assertion failed (nm_setting_vpn_get_data_item (s_vpn, item) == expected): ("/home/michael/debian/build-area/network-manager-openvpn-1.1.91/properties/tests/conf/Att\344taenko.pem" == "/home/michael/debian/build-area/network-manager-openvpn-1.1.91/properties/tests/conf/Att\303\244taenko.pem")
FAIL test-import-export (exit status: 134)

FAIL: test-import-export-glib
=============================

/ovpn/properties/test_password_import: OK
/ovpn/properties/test_password_export: OK
/ovpn/properties/test_tls_import: OK
/ovpn/properties/test_tls_inline_import: OK
/ovpn/properties/test_tls_export: OK
/ovpn/properties/test_pkcs12_import: OK
/ovpn/properties/test_pkcs12_export: OK
/ovpn/properties/test_non_utf8_import: **
ERROR:test-import-export.c:86:_check_item: assertion failed (nm_setting_vpn_get_data_item (s_vpn, item) == expected): ("/home/michael/debian/build-area/network-manager-openvpn-1.1.91/properties/tests/conf/Att\344taenko.pem" == "/home/michael/debian/build-area/network-manager-openvpn-1.1.91/properties/tests/conf/Att\303\244taenko.pem")
FAIL test-import-export-glib (exit status: 134)
Comment 1 Thomas Haller 2016-03-02 09:57:01 UTC 
Hm, doesn't fail for me.

What is your language setting when the test fails? LANG, LANGUAGE, LC*?
Comment 2 Thomas Haller 2016-03-02 11:56:41 UTC 
let's not handle encodings during import: https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00011.html
Comment 3 Michael Biebl 2016-03-02 14:47:15 UTC 
(In reply to Thomas Haller from comment #1)
> Hm, doesn't fail for me.

That's odd.

> What is your language setting when the test fails? LANG, LANGUAGE, LC*?

I tried different locales. My default de_DE.UTF-8
$ locale
LANG=de_DE.UTF-8
LANGUAGE=
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

But also with "export LANG=C" and "export LANG=C.UTF-8"
Comment 4 Thomas Haller 2016-03-03 12:46:02 UTC 
I anyway would like to change handling of non-UTF8-encodings, which will fix this too.

Depending on bug 763039...
Comment 5 Thomas Haller 2016-03-08 14:15:28 UTC 
as bug 763039 is closed by merging branch [1], I think this issue can no longer happen.

Closing.


[1] https://git.gnome.org/browse/network-manager-openvpn/commit/?id=a5aa60041018cff200a8aded7afd437e5ec21a79