After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762902 - GDK W32: Newly-opened windows (such as popups) have unthemed cursor
GDK W32: Newly-opened windows (such as popups) have unthemed cursor
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-01 03:46 UTC by LRN
Modified: 2016-03-03 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GDK W32: Set default cursor from our own theme right away (1.68 KB, patch)
2016-03-01 03:46 UTC, LRN 		none Details | Review
GDK W32: Set default cursor from our own theme right away (1.68 KB, patch)
2016-03-03 07:25 UTC, LRN 		committed Details | Review

Description LRN 2016-03-01 03:46:44 UTC 
How to reproduce:
* Run any app (widget-factory works)
* Set cursor theme to Adwaita
* Open a popup (use any menu or combo box)

Expected result:
* Popup should use Adwaita left_ptr cursor

Actual result:
* Popup uses default Windows left_ptr cursor and
  switches to Adwaita left_ptr cursor only when re-opened
Comment 1 LRN 2016-03-01 03:46:50 UTC 
Created attachment 322717 [details] [review]
GDK W32: Set default cursor from our own theme right away

Otherwise WM-dependent default cursor is used, which does not
match our theme. Worse, later GDK will realize that we have
our own left_ptr cursor and will apply it after all, making
the discrepancy even more noticeable.
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-03-01 08:10:27 UTC 
Review of attachment 322717 [details] [review]:

Patch looks good. Just see the minor comment.

::: gdk/win32/gdkwindow-win32.c
@@ +152,3 @@
   impl->changing_state = FALSE;
+
+  if (display)

let's be more explicit and use: display != NULL
Comment 3 LRN 2016-03-03 07:25:12 UTC 
Created attachment 322949 [details] [review]
GDK W32: Set default cursor from our own theme right away

v2:
* Fixed a nitpick
Comment 4 Ignacio Casal Quinteiro (nacho) 2016-03-03 07:28:45 UTC 
Review of attachment 322949 [details] [review]:

Looks good.
Comment 5 LRN 2016-03-03 07:31:37 UTC 
Attachment 322949 [details] pushed as ba89fbd - GDK W32: Set default cursor from our own theme right away