After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762787 - dvdreadsrc: Seeking forgets title
dvdreadsrc: Seeking forgets title
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 1.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
1.6.4
Depends on:
Blocks:
 
 
Reported: 2016-02-27 18:45 UTC by Jens Georg
Modified: 2016-04-14 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvdread: Fix seek starting at 0 for title != 1 (944 bytes, patch)
2016-02-27 19:20 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2016-02-27 18:45:51 UTC 
When using gst_element_seek on a pipeline containing dvdreadsrc and a title different to 1, there seems to be an issue in time -> sector mapping.

Example:

gst_element_seek (pipeline, 1.0, GST_FORMAT_TIME, GST_SEEK_FLAG_FLUSH | GST_SEEK_FLAG_KEY_UNIT, GST_SEEK_TYPE_SET, start, GST_SEEK_TYPE_SET, end)

if start == 0, I get the sector "0" and end up in title 1.

dvdreadsrc.c:1275:gst_dvd_read_src_do_seek:<dvdreadsrc0> Time 0:00:00.000000000 => sector 0

If I set start to 1 second, I get the proper offset for the current title:
dvdreadsrc.c:1275:gst_dvd_read_src_do_seek:<dvdreadsrc0> Time 0:00:01.000000000 => sector 514961
Comment 1 Jens Georg 2016-02-27 19:20:59 UTC 
Created attachment 322549 [details] [review]
dvdread: Fix seek starting at 0 for title != 1

Otherwise the playback would start at title 0
Comment 2 Jens Georg 2016-02-27 19:21:31 UTC 
This seems to fix it for me. I have tested that seeking on title 1 still works, but not much more.
Comment 3 Jan Schmidt 2016-02-28 12:35:25 UTC 
Review of attachment 322549 [details] [review]:

Looks good, thanks!