After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762677 - gtkplacessidebar: avoid irresponsible UI while trashing
gtkplacessidebar: avoid irresponsible UI while trashing
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 686332 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-02-25 13:35 UTC by Carlos Soriano
Modified: 2016-07-29 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkplacessidebar: avoid irresponsible UI while trashing (5.31 KB, patch)
2016-02-25 13:35 UTC, Carlos Soriano 		reviewed Details | Review

Description Carlos Soriano 2016-02-25 13:35:40 UTC 
Found while reviewing nautilus improvements on 762126
Comment 1 Carlos Soriano 2016-02-25 13:35:44 UTC 
Created attachment 322371 [details] [review]
gtkplacessidebar: avoid irresponsible UI while trashing

We were updating the whole places sidebar when the trash changed.
This effectively removes all rows and create new ones for every trash
state change.

Although when using GtkTreeView it was somehow ok, with the new
implementation with GtkListBox this effectively locks the UI while the
trash operations are being performed.

When performing operations for i.e. 100 files, the UI can be locked
for more than 1 minute since gvfs-trash usually takes time.

To fix this just update the icon of the trash when the state of the
trash change instead of the whole sidebar.
Comment 2 Matthias Clasen 2016-02-25 13:38:50 UTC 
Review of attachment 322371 [details] [review]:

that makes a lot of sense. Please update the commit message to say "unresponsive" instead of "irresponsible" though. Those are different things...
Comment 3 Carlos Soriano 2016-02-25 13:47:46 UTC 
Ugh right. Pushed with the commit fix.
Comment 4 Carlos Soriano 2016-02-25 14:03:24 UTC 
hm git bz failed. Here's the commit: https://git.gnome.org/browse/gtk+/commit/?id=20cf42c9ea977fe441c297a531811990876575c7
Comment 5 Carlos Soriano 2016-07-29 09:55:01 UTC 
*** Bug 686332 has been marked as a duplicate of this bug. ***